Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unify the kcl run cli #105

Merged
merged 2 commits into from
Jul 11, 2024
Merged

feat: unify the kcl run cli #105

merged 2 commits into from
Jul 11, 2024

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re kcl-lang/kpm#289

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@zong-zhe zong-zhe added the enhancement New feature or request label Jul 11, 2024
@zong-zhe zong-zhe requested a review from Peefy July 11, 2024 08:08
@zong-zhe zong-zhe self-assigned this Jul 11, 2024
@coveralls
Copy link

coveralls commented Jul 11, 2024

Pull Request Test Coverage Report for Build 9888441573

Details

  • 30 of 94 (31.91%) changed or added relevant lines in 1 file are covered.
  • 51 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-11.2%) to 16.473%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/options/run.go 30 94 31.91%
Files with Coverage Reduction New Missed Lines %
pkg/fs/util.go 9 0.0%
pkg/options/run.go 42 27.31%
Totals Coverage Status
Change from base Build 9867408207: -11.2%
Covered Lines: 85
Relevant Lines: 516

💛 - Coveralls

@@ -199,7 +141,62 @@ func (o *RunOptions) Run() error {

// Complete completes the options based on the provided arguments.
func (o *RunOptions) Complete(args []string) error {
o.Entries = args
if len(o.Git) != 0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can add some validation for entries and git, oci source.

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 5cd6bc7 into kcl-lang:main Jul 11, 2024
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants